HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
12k stars 4.09k forks source link

Skeleton Panda Mount Head Shift #3954

Closed zincotroid closed 9 years ago

zincotroid commented 10 years ago

image

The skeleton panda mount's head looks like it's too far left, at least compared to the other panda mounts.

image

ebiagogo commented 10 years ago

I have this fixed locally and can commit it once I read the the Artisan guide to make sure I submit the change correctly.

deilann commented 10 years ago

You'll need to submit arts permissions if you haven't already, so habit has the rights to use the altered image. I know it's just a shift, but it's still a change. :) You can find the info for permissions on the pixel art trello. If you don't know where that is or can't find it, let me know. On Aug 31, 2014 1:32 PM, "ebiagogo" notifications@github.com wrote:

I have this fixed locally and can commit it once I read the the Artisan guide to make sure I submit the change correctly.

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/3954#issuecomment-54000366.

ebiagogo commented 10 years ago

Yup, I found it earlier and saw there's a bit to read through which is why it's going to take me a little bit longer to commit it. It'll probably take more time for me to read through it and finish the steps than it took me to shift the image. :) It's all good though, I understand the reason the policies are in place. Thanks much for the info.

deilann commented 10 years ago

Awesome. :) On Aug 31, 2014 2:12 PM, "ebiagogo" notifications@github.com wrote:

Yup, I found it earlier and saw there's a bit to read through which is why it's going to take me a little bit longer to commit it. It'll probably take more time for me to read through it and finish the steps than it took me to shift the image. :) It's all good though, I understand the reason the policies are in place. Thanks much for the info.

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/3954#issuecomment-54001466.

zincotroid commented 10 years ago

Thanks guys, maybe some day I'll be able to make edits like this on my own. I just haven't sat down and figured out things like the Art Permissions, but I would like to contribute. I might start out trying my hand at writing a quest :)

ebiagogo commented 10 years ago

So I'm trying to test the change to the Skeleton panda mount on my local habitrpg and I keep getting an error when trying to recreate the spritesmith png files (grunt sprite under habitrpg-shared. The documentation seems to be sparse on building shared but I think I have things set up correctly. I keep getting the following error when it gets to the sprite:3 task:

... Running "sprite:2" (sprite) task Files "dist/spritesmith2.css", "dist/spritesmith2.png" created.

Running "sprite:3" (sprite) task Fatal error: Unsupported interlace method.

I thought maybe the new panda file was causing the error (even though I think the head is on the spritesmith5.png) so I reverted back to the most recent source and still get the error.

Thanks,

Michael

ebiagogo commented 10 years ago

It looks like the img/sprites/spritesmith/quests/quest_atom1.png is causing the "Unsupported interlace method" error. I'm not sure why. I opened it in gimp and just exported it again and recreated the sprites without an issue. I was then able to verify the new panda mount head locally.

I don't want to commit changes to the quest_atom1.png without confirmation that there's some issue with it. Also, does one commit the new dist directory and its contents after making a change to the sprites or is that directory generated as part of the build?

ebiagogo commented 10 years ago

submitted a pull request over on habitrpg-shared