HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.98k stars 4.09k forks source link

Share Avatar options are intrusive #4277

Closed SabreCat closed 8 years ago

SabreCat commented 9 years ago

The ability to share one's HabitRPG avatar is a clever addition! It's a good way to spread the word about the site and celebrate one's accomplishments. However, I'm finding that it's in my face a little too often.

2014-11-25 14_56_31-clipboard All I want is to click my avatar to flip screens! grrblmrgrysnarklecheeses

Several times a session, I accidentally trip the mouseover, getting the share options dropdown, and need to waggle the mouse around a bit to get it to go away. Given that sharing one's avatar is not an everyday kind of action in most cases, this is more annoying than helpful.

Suggestions:

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

lefnire commented 9 years ago

Another possibility: explore some of the other share options, I find addthis a bit clunky (albeit functional, which is why I did it). One alternative I know of is sharethis. Though definitely down with the "on click" suggestion, could someone poke around to see if there's such an option in addthis?

aedunn6 commented 9 years ago

Agree. I try to click on backgrounds, and the share menu pops up through the dropdown! screen shot 2014-12-02 at 10 14 31 pm

SabreCat commented 9 years ago

In the meantime, users of browser extensions for blocking intrusive elements like this can nail it with a filter on the atm-i class of div.

Alys commented 9 years ago

Try installing this and then modify it for the Share icon instead of the Level: http://habitrpg.wikia.com/wiki/Hide_Level_Numbers

On 7 December 2014 at 02:02, Sabe Jones notifications@github.com wrote:

In the meantime, might there be a way for me to block this using a browser extension? It is driving me loopy.

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/4277#issuecomment-65903190.

benmanley commented 9 years ago

This is the code to disable hover, but I’m not sure where to put it:

var addthis_config = {
    ui_click: true 
}

addthis documentation

Also, if the share button stays inside the herobox, I would prefer if it was in the bottom left corner as it currently obscures longer avatar names.

share

Any objections?

crookedneighbor commented 9 years ago

@benblank it goes here

That's fine with me, and putting it at the bottom left also makes me less likely to trigger it accidentally.

benmanley commented 9 years ago

Thanks @crookedneighbor.

I’ve gone for it and committed a fix disabling hover (45d30ffef56cdec74849448195e9cca02af58d7d) and moving the share button to the bottom left (0943a229ec5cbb976e204ec7ec4641b138aea39b) . I've left this issue open as there’s still discussion to be had about whether the sharing button should be in the avatar box.

PS I’m @benmanley not benblank, just so we don’t pester him any more ;-)

crookedneighbor commented 9 years ago

Hah. Whoops. My fingers knew who you were, but my eyes and the keyboard apparently did not.

crookedneighbor commented 9 years ago

@benmanley Just rebased off your commits, and I noticed that now that it requires a click to activate, it's also activating the normal click action on the avatar to take the user to the profile page (or the tasks page if already on the profile page).

I don't think that's a big deal, but it was unexpected.

benmanley commented 9 years ago

Yeah. I noticed that. This was already the behaviour when you clicked. It needs sorting out somehow but I figured it was less irritating than the hover problem.

crookedneighbor commented 9 years ago

Oh, it's definitely much better.

librarianmage commented 8 years ago

@crookedneighbor Has this been disabled?

SabreCat commented 8 years ago

@MathWhiz It got moved to a much less obnoxious position and made to pop out only on click. I think this is solved!