HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.95k stars 4.08k forks source link

Accepted party invite, but Invitation doesn't disappear #5649

Closed AquelePedro closed 8 years ago

AquelePedro commented 9 years ago

I was invited to Brasil Team party and accepted, but the invitation remains

Already left party and accepted invitation again, but it didn't make the invitation go away. Tried that using Chrome and Firefox @ Windows and then Chrome and Firefox @ Linux, still the same result.

edit by admin:

The information below will no longer work. If you can't remove a party invitation, please go to Help > Report a Bug from the Habitica website's menu, or Guilds > Report a Bug on the mobile app (both take you to the same guild). An admin will delete the invitation when they see your message.

Alternatively you can post on this issue if you wish. Even though it's closed, we'll still see your message and help you. If you post here, you do not need to also report it in the guild.

Follow the steps below exactly as they are listed.

If at any time during these steps, you see the red error message box on the right hand side of the page, reload the page, and try to continue the instructions from where you were up to (or from the start if that makes things easier).

  1. Go to the party page.
  2. Decline the invitation.
  3. IMMEDIATELY clear your browser's cookies for habitica.com. Don't do ANYTHING else between declining the invitation and clearing the cookies (don't log out, don't reload, nor anything else).
  4. Reload Habitica. You'll find you're logged out (if you aren't, then clear cookies again).
  5. Log in.
  6. If the login doesn't work (e.g., the login form doesn't disappear after you click the login button) then reload the page and log in again. This second login should work.
  7. If the invitation is still there, go to your party page and decline it again.
  8. IMMEDIATELY clear your browser's cookies for habitica.com again. Don't do ANYTHING else between declining the invitation and clearing the cookies.
  9. Reload Habitica, log in again.
  10. You should now find that the invitation is gone permanently. If it is not, double-check that you followed exactly those instructions, and if you are certain that you did, comment here to tell us that it didn't work. If anything happened that didn't seem to match what these instructions say, please describe it.

If you still have an email that contains an invitation link for a party, delete the email. Do not click on that link again.

Those instructions should permanently delete the invitation that keeps asking you if you want to join the party. However your name will still be listed in the list of people invited to the party (as well as in the list of party members) but we are considering that to be a lower priority bug since it is less annoying. We are sorry about the inconvenience.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Alys commented 9 years ago

We'll need your user ID to help with this. If you don't know how to get your User ID, go to Help -> Report a Bug and see step 6.

AquelePedro commented 9 years ago

Here it is:

4e3e2f5f-42b8-4aef-9059-8c8c07cd2a1b

SpenserJ commented 9 years ago

Does this go hand-in-hand with active members still appearing in the invite list? Glitchy member list Sammy7131 (highlighting is mine) appears in both the invited and member list of my party, and I've had a few other users appear this way. When I removed an inactive member (also in the invite list), he disappeared from the member list, but was still listed as invited. After removing him the second time, all trace of the user was finally gone from the lists. Sammy7131's ID is 9b044b09-909e-415f-8c67-495246489cf4.

Alys commented 9 years ago

@Tsvet I've removed the invitation from your account. Please tell us if that hasn't fixed the problem. Do you know if the invitation was sent by specifying your email address or your user ID?

@SpenserJ Yes, that probably is related. Did you send the invitation to Sammy7131? Do you recall if it was by email or ID? In Sammy7131's account, there is still an active invitation so I would be interested to know if that person appears back in the invite list.

SpenserJ commented 9 years ago

@Alys I invited Sammy7131 via ID, and it was the same for the other users who appeared in both lists (sadly I didn't write down their names). I'll keep an eye out for this happening again, and try to reproduce it locally. I'm not seeing anything in the code (website/src/controllers/groups.js - Line 434-483) that stands out as potentially flawed.

Alys commented 9 years ago

Another report of this was sent by email (below). I've deleted the invitation.

Hi, I was messing around and somehow got a notification (invitation to a guild) that won’t go away. Would you delete it for me? It puts a little person icon in the messages status, so I don’t see when I have new chat messages. L

My UUID: 9173198f-4777-4a35-9f03-8aea24f51782

"invitations": { "party": { "id": "2fdfb274-3286-439f-b8ec-c480f7066405", "inviter": "9173198f-4777-4a35-9f03-8aea24f51782", "name": "Students of the Bear" }, "guilds": [] },

Strangely, this is a guild; not a party. Not sure why it’s under party and not guild…

How this happened: I was trying to figure out if the email invitation link could just be sent to anyone, or if it was email address specific. In the process, I guess I invited myself to my own guild a couple of times. I hit the decline invitation button, and that got rid of one notification, but not the other. I tried leaving that guild, but the notification remains.

Thanks! Edward Shapard (Sir Edward)

Taejang commented 9 years ago

We had two players appearing as both active and invited. As the party leader, I tried to remove a party invitation, but it instead removed the player from both the invite section and the active list, booting him from the party entirely. After another invite, that player shows as active and not under invited. The second user still shows as both invited and active.

The first time invites were sent to both players, it was by email. The second time (after the player was booted from the party), I added him back with the ID. A third player was invited via email and, after accepting, was successfully added to the active list and removed from the invited list.

religigeek commented 9 years ago

I have been experiencing this issue as well. I joined via an email link from a friend two days ago. Signed in, accepted the invitation, then the invitation still appears. Tried multiple browsers on multiple computers and it still persists.

User ID: 7993e524-9734-4d3d-8471-e9bab192d716 Party: I Like Cake

Alys commented 9 years ago

@religigeek I can't see any invitations saved in your account or in that party. Please tell us if the problem still appears at your end.

religigeek commented 9 years ago

It looks like it finally disappeared. I will update if it shows up again.

On Sat, Oct 10, 2015 at 3:16 PM, Alys notifications@github.com wrote:

@religigeek https://github.com/religigeek I can't see any invitations saved in your account or in that party. Please tell us if the problem still appears at your end.

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/5649#issuecomment-147122391.

swistak commented 9 years ago

Same issue here user id: a847788d-5f96-4bf3-94c5-7e1ac7b4cb0c Joined via email link to.

This is still happening and not resolved for me. group id: 8a9fb119-fce7-40a9-93d7-bac37a4f0d42

See also ticket #6051

Alys commented 9 years ago

@swistak There's no invitations remaining in your user account or in the party you're a member of. Please log out of Habitica, clear your browser's cache, and local storage, close all browser windows, and then see if the invitation has disappeared. Sorry about the trouble! I think it's just a local caching/storage issue.

swistak commented 9 years ago

Yea. Seems this has been solved with other ticket and it remained in cache for some reason.

Looks like there's a problem with angular loading twice when you enter habitica through deep link (eg. #/tasks ). I'm trying to track it down, to create reproducible example.

All this trouble just reinforces my opinion that angular is just horrible, undebugable pile of garbage.

dirad commented 9 years ago

i just had this issue. Invited a new user which logged in via facebook, and had this hanging invite issue. They also showed up twice in my list. Once as Member and once as invited.

They could only get rid of it after i deleted them from the invites..

cTheDragons commented 9 years ago

Hi,

We are also experience the same issue with our party Group ID: e3c001ca-f0dd-4510-b313-ba38dbfc7294

for the user asympt0te d36de64c-b5d5-4aba-a3be-6df41c39efa6

They are appearing both in the party list and the invited list.

(We are also concern that the others on the invited list have already reject the invite but they are still 'HANGING around')

Also have logged into multiple computers and browser and still see the invite.

Thanks cTheDragons

Alys commented 9 years ago

@cTheDragons Can you please ask the party leader to cancel the invitations? They might have to do that a couple of times before they disappear permanently. Please tell us if that doesn't work.

cTheDragons commented 9 years ago

Hi Alys,

Thanks @Alys for your quick response. I am the party leader (sorry for not being clear).

With the invite for user asympt0te _d36de64c-b5d5-4aba-a3be-6df41c39efa6_ they are already part of the party and the quest. I'm concern if I cancel the invite I will kick them from the group, particular in light of the comments above.

With the other invitees I will cancel myself. (I will wait 24 hours to ensure they actually don't want to be apart of the group).

Thanks again. cTheDragons

Alys commented 9 years ago

@cTheDragons I've deleted the invitation for d36de64c-b5d5-4aba-a3be-6df41c39efa6.

cTheDragons commented 9 years ago

Thanks @Alys All seems to be good.

chamini2 commented 8 years ago

Hello, I'm not the party leader of my party, but I see there's three invites for three people already in the members list, the Group ID is fbd39690-cb18-4f65-9a92-55a781e133a3

Hope someone can give me a hand fixing this?

Alys commented 8 years ago

@chamini2 I've removed the invitations. It's not unheard of for them to come back, so comment here again if they do.

JamesOwers commented 8 years ago

I have the same issue. Was invited to a party by multiple members and now the invitation persists even though I am already a member. I'm also still on the 'invited' list. uuid=36b11762-799c-4719-8b66-a10c6da05c5e

Alys commented 8 years ago

@kungfujam I've fixed that for you, but it's not unheard of for it to come back. If it does, comment here again and also clear local storage for your browser (you might need to google for how that's done, for some browsers it's different than clearing the cache).

JamesOwers commented 8 years ago

Cheers, that's worked but only after again accepting the invitation.

danielvancamp commented 8 years ago

Same issue here, both joined and were invited by mail. Group ID : 793119dc-6589-4dff-8282-1ffd3dd32671

Alys commented 8 years ago

@danielvancamp Affected users are 5d91a8fb-4781-4f1d-a040-a10f58c99348 and 0ce5bf69-77cc-4c14-9ab5-97a5ed128ac6. I've removed the invitations for them, but they often come back a few times. I'll check again a couple of times a day for the next few days and remove them again if needed. If you notice the same problem for those users a week from now, please comment again here.

swistak commented 8 years ago

Maybe you should use those cases to locate a root cause for this?

Alys commented 8 years ago

@swistak yes, that's what we've been doing. It's most likely to be a local storage issue, and we'll be investigating removing or adjusting the use of local storage when a large project to significantly improve the code base is finished.

pseudocyesis commented 8 years ago

Hello! I'm having the same problem with the invite not disappearing. ID below! Thanks :)

d7f1e549-d4ef-43b5-a277-934a9f7b9a21

Alys commented 8 years ago

@pseudocyesis I've removed the invitation, but it's not unknown for it to come back a few times. I'll check again a couple of times a day for the next few days and remove it again if needed. If you notice the same problem a week from now, please comment again here.

erica3219 commented 8 years ago

http://i.imgur.com/YrOLL5y.jpg having same problem here as well. UUID: 9bab6b19-9cea-4f1c-b9e8-5c54c61a549d Thanks

Alys commented 8 years ago

@erica3219 I've removed the invitation, but it's not unknown for it to come back a few times. I'll check again a couple of times a day for the next few days and remove it again if needed. If you notice the same problem a week from now, please comment again here.

erica3219 commented 8 years ago

As well, I attend a party, but I cast none damage to the monster. I mean, I am cleared my to dos and dailies, however, there was neither text coming up said how much damage I cast nor the blood on monster really gone. But I can use skills as usual.

Alys commented 8 years ago

@erica3219 That won't have been caused by the invitation. There's nothing wrong in your account for the party's quest, so I don't think there's a bug. If the quest has only just started, no one will have damaged it yet. Damage is dealt by each player only once a day (when they first use Habitica each day). If you need extra information about this, please go to Help -> Ask a Question from the Habitica website, and we'll give you more details there.

erica3219 commented 8 years ago

Thanks a lot :+1:

pseudocyesis commented 8 years ago

Hey @Alys, still seeing the invitation on my account, hoping to see if you had any new tricks up your sleeve! Thanks

ID again: d7f1e549-d4ef-43b5-a277-934a9f7b9a21

Alys commented 8 years ago

@pseudocyesis Yes, it keeps appearing. :( I've seen it and removed it several times over the past week. I'm checking twice every day and I'll keep doing that until I see it stop coming back for a few days in a row. I'm afraid it's just a matter of waiting until it clears properly. When we finish some major site upgrades, we'll look into whether our use of local storage can be improved, which I think is what this is related to. I'm really sorry about the trouble!

jpazniokas commented 8 years ago

I just accidentally booted a player mid-quest by attempting to delete a non-disappearing invite, as per this bug.

Out of curiosity, is there any way to get a player back into a quest after being invited back into the party? It's unfortunate: the player in question has done the bulk of the damage over the last two days.

Alys commented 8 years ago

@jpazniokas There isn't normally but if you give us their uuid after they are back in the party, we can put them back in the quest, since this happened as a result of a bug. We would not usually do that in non-bug circumstances.

jpazniokas commented 8 years ago

Thank you so much, @Alys .

b291b934-7d0b-4936-8818-4daeab575211

I appreciate it. If it were a simple matter of XP, gold and items, I would have just hacked the rewards together myself. But there are also two pieces of equipment and an achievement involved too. :)

Alys commented 8 years ago

@jpazniokas They should be back in the quest now. Please reload your own party page and look at the list of quest participants. Tell me if they don't appear or if anything looks odd. Check tomorrow after they have been through cron to see if a message appears in party chat about their quest progress. Tell me then if that's not right either.

You have another player in the party with this invitations problem. I've just deleted their excess invitation. It might come back a few times, so I'll be checking twice a day for the next few days until it's deleted for good (FYI, I have this scripted so it's very little trouble to do). If there are still invitations left in a week, comment here again.

jpazniokas commented 8 years ago

Thank you, @Alys , and not a moment too soon: little did I know that another party member dumped all of their mana into Brutal Smashes: the quest boss had a mere two hours left to live!

I'll let you know about superfluous invites if you like, but I'm a programmer too: this is a pretty low-priority one with everything else y'all have going on, and it's pretty easy to work around: just ignore it.

Thanks again.

JFDama commented 8 years ago

Hi @Alys, a party I joined recently, group UUID 1ea2408e-4c4e-4aeb-aa29-924a350ad0fc, is seeing this problem for most of our joined members as well. Would you mind taking care of this for us?

The UUIDs of the players with this issue in the party are e7f03b14-5a7f-4539-98b7-0eec0b92872a ec1989c9-51ab-4099-9225-7ae8d0a21f8c 7a9669fc-ddb8-41d8-b294-57b51164ba32 9349b978-c25e-40a8-8e8d-2d3ed6e0d5e6 e1e87003-5771-44a1-b5fe-60796e64df8f a99b33dc-b030-4bed-8573-d16b6847cff3 5a1bf377-517d-4c2c-b2a3-13b3f89294fa

Thanks!

Alys commented 8 years ago

@JFDama I've deleted those invitations. They typically come back several times over a few days so I'll keep checking at least twice a day and delete them when I see them. It's unusual to get so many at once, so I'd like to work out why. Do you know if all those people were invited at the same time? And were they all invited by the same person? Can you tell me who that was?

JFDama commented 8 years ago

@Alys, thank you!

These people were not all invited at the same time or all by the same person. In fact, it might be the opposite--I joined later than most, so I can't report the full history, but 9349b978-c25e-40a8-8e8d-2d3ed6e0d5e6 invited me, e1e87003-5771-44a1-b5fe-60796e64df8f, two weeks ago, then I invited a99b33dc-b030-4bed-8573-d16b6847cff3 3 days after, and he invited 5a1bf377-517d-4c2c-b2a3-13b3f89294fa yesterday. So the part of the history I know has been more like a sequential chain than a broadcast, and weeks have gone between some of these invitations.

Alys commented 8 years ago

@JFDama Well that blows my theory out of the water. :) Thank you very much for the details!

JFDama commented 8 years ago

@Alys Thank you again for the fix!

jozefspisiak commented 8 years ago

Same bug here. I accepted invitation and it sticks, even if I accept it multiple times afterwards. User ID: 700a11ad-ee57-461e-b6f8-8af962e79f1c Group ID: 79bfa2eb-9778-4187-97c9-6d6aeb45b523

Other members of group are as well affected.

Alys commented 8 years ago

@jozefspisiak I've deleted the invitations, but please read the bold text at the top of this page, if you haven't already.

jozefspisiak commented 8 years ago

@Alys yes, thank you. The invitation still shows up, but as I read they will reappear for couple of days. Can you maybe check access logs, if they are enabled to see if there were multiple ajax calls which created them or only one? If the problem is in the browser or only on the server side.

Also we have all registered to habitica after we received email invitation to join party from a friend, which came: Wed, 6 Jan 2016 09:36:49 -0800 (PST) and my user was created Thu, 7 Jan 2016 00:44:41 -0800 (PST) and I first time accepted invitation few minutes afterwards. Just though this might be important.