search

HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
12k stars 4.1k forks source link

Avatar clipping in the wrong spots #6356

Closed Zer0t3ch closed 8 years ago

Zer0t3ch commented 8 years ago

Not sure if this is the right place for this issue, but it's just something that I noticed on Habitica.com http://i.imgur.com/V5HoHAf.png This was noted with the "Absurd Party Robes" used as part of the costume on the "Royal Purple Gryphon" mount.

User ID: 17bbc7b9-95bf-48b1-9bab-c550c2084c0b OS: Windows 7 Pro Browser: Firefox 42

pnrich commented 8 years ago

This is actually the intended effect. Each mount is represented by 3 different .png files, only two of which are included in the generation of the avatar. The mount's body is added before anything else, then the character sprite (including armor), then the mount's head. This, I presume, is supposed to give the effect of 'riding' your mount. However, with some of the armor-mount combinations, such as the one you have here, the sprites do not mesh exceedingly well.

Zer0t3ch commented 8 years ago

@pnrich So is this something that needs to be changed?

pnrich commented 8 years ago

It may be something to refer to the designers and pixel artists, but the code is working exactly as it should.

Zer0t3ch commented 8 years ago

Okay, fair enough. Thanks.

crookedneighbor commented 8 years ago

@lemoness Please review this issue.

gryphon and party robes

lemoness commented 8 years ago

So, we could re-layer the art for the gryphon to prevent this from happening, which I think would probably look better. I'll add it to the list of things we need on Trello.

lemoness commented 8 years ago

The re-layers have been completed by the talented @nonight! They're ready to be put in-game. If there's any issue with the following files, let me know.

mount_body_gryphon-base1xb_zpsi4kotjft mount_body_gryphon-base1xf_zpsdhfstxc8 mount_body_gryphon-red1_zpsxyptrafs mount_body_gryphon-pink1_zpsaelj6ihh mount_body_gryphon-desert1_zpsewjzckrv mount_body_gryphon-gold1_zpsrbd2jigk mount_body_gryphon-shade1_zps33yxt9sa mount_body_gryphon-white1_zpszo68oxqt mount_body_gryphon-blue1_zpssnslnmjs mount_body_gryphon-zombie1_zpsmnggnhkz mount_head_gryphon-blue1_zpshj42gvry mount_head_gryphon-desert1_zpsvhqk93wi mount_head_gryphon-pink1_zpspynanboj mount_head_gryphon-red1_zpscawzdydq mount_head_gryphon-gold1_zpsk25awhw3 mount_head_gryphon-white1_zpsyekeodoo mount_head_gryphon-shade1_zpsd2raylur mount_head_gryphon-zombie1_zpsjdpu5ynj mount_body_gryphon-royal1_zps7rb8u13h mount_head_gryphon-royal1_zpstazajnu2 mount_body_gryphon-skeleton2_zpspiemdhyb mount_head_gryphon-skeleton2_zpsc3viihfb

taldin commented 8 years ago

So the solution for this one is to download these PNG files, copy them into the spritesmith directories on top of the old ones, and then grunt spritesmith, then pull, yes?

crookedneighbor commented 8 years ago

Yes, except that we're no longer using grunt for it. You can run the sprite task with:

npm run sprites
taldin commented 8 years ago

Aha, so the Wiki recording is out of date. I'll take this one for a spin for today's blog post.