search

HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.65k stars 4.04k forks source link

Critical hits on skill use are not reported in notifications #8128

Open SabreCat opened 7 years ago

SabreCat commented 7 years ago

General Info

It is possible to score a critical hit with actions like Brutal Smash, lending a modest boost to the damage done to a boss. However, unlike critical hits when scoring tasks, there is no feedback in notifications that this has occurred. In the past, this was difficult to notice, but now that we have immediate output of boss damage, it's clear that sometimes you randomly get more progress without any indication as to why. We should fire the critical hit starburst including the relevant bonus amount when landing skill crits.

Console Errors

None

librarianmage commented 4 years ago

Is this still an issue?

Alys commented 4 years ago

Yes, this is still an issue.

Note to anyone working on this, currently you can't see how much boss damage you do from notifications due to https://github.com/HabitRPG/habitica/issues/11828 but you can watch how your test account's party.quest.progress.up changes in your local database.

I've removed some old comments from this issue (just requests to work on this and confirmations/questions related to them).

HerrMoriden commented 3 years ago

is this still an issue ? would like to work on this

Alys commented 3 years ago

@HerrMoriden You have a couple of other issues assigned to you so we'll keep this one open for someone else to work on. When you've finished the other issues, post again here if you'd like to claim this one. Please see this comment from Matteo about claiming just one issue at a time.

lstanford53 commented 1 year ago

Hi, does this still need to be implemented? I looked into the code and I think I'd be able to implement this. Let me know if I can help.

CuriousMagpie commented 1 year ago

@lstanford53 Feel free to take this on! Thanks!

lstanford53 commented 1 year ago

Sure, I'll start on it now.

lstanford53 commented 1 year ago

@CuriousMagpie Hello, I have opened a PR that fixes this issue. Here's the link: https://github.com/HabitRPG/habitica/pull/14696