search

HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.81k stars 4.05k forks source link

Updates to the Equipment Page #9458

Closed lemoness closed 3 years ago

lemoness commented 6 years ago

We need to implement some changes to the Equipment page based on feedback from users, as well as to reinstate the Unequip All buttons!

screen shot 2017-11-09 at 7 15 52 pm screen shot 2017-11-09 at 7 16 48 pm

Whoever works on this ticket will need to be added to our Zeplin so they can get all the full designs and talk with @Tressley about the details, so we'll need to know which email address to invite.

Tressley commented 6 years ago

@lemoness -- In addition to the page-level updates, there are design changes to the Drawer component that are a bit more technical. Would you like to break that out into a separate issue? It specifically touches on Drawers that have tabs (e.g. Quick Inventory.)

librarianmage commented 6 years ago

As far as I can tell, the updates include:

is that correct?

Tressley commented 6 years ago

@MathWhiz -- Good eyes! Your list pretty much hit all of the changes. There are a couple more to add.

librarianmage commented 6 years ago

I'd like to try this, but I don't know if I can actually do it.

lemoness commented 6 years ago

@MathWhiz I'll assign it to you for now, but let us know if you hit a wall. What email address should we invite to Zeplin?

Tressley commented 6 years ago

@MathWhiz -- Zeplin invite sent your way. You can find the Zeplin artboards here:

Alys commented 6 years ago

When this issue is resolved, https://github.com/HabitRPG/habitica/issues/8781 should be taken off hold.

Alys commented 6 years ago

@Tressley Can you invite me to the project too, as well as MathWhiz? alys@habitica.com

Can we use better wording for "You have disabled your costume"? All players start with the costume off by default, so they will see that message as soon as they go to the Costume tab, which will be confusing and misleading since they themselves haven't disabled anything. Also now that the "Use costume" toggle is in a completely different part of the page, it's going to be hard for them to work out how they can enable the costume. Can the message please explain that? Something like "Your costume is disabled. Enable it by clicking 'Use Costume' at the top of this page." would be more helpful.

Tressley commented 6 years ago

@MathWhiz / @Alys -- I believe you are both members now. Please let me know if there's still an issue!

As for the wording, I'm not opposed to clearer wording. I like what you've suggested, but will tag-in @lemoness for copy approval.

lemoness commented 6 years ago

I like the wording that Alys has suggested!

On Mon, Nov 27, 2017 at 10:22 AM, Tressley Cahill notifications@github.com wrote:

@MathWhiz https://github.com/mathwhiz / @Alys https://github.com/alys -- I believe you are both members now. Please let me know if there's still an issue!

As for the wording, I'm not opposed to clearer wording. I like what you've suggested, but will tag-in @lemoness https://github.com/lemoness for copy approval.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitica/issues/9458#issuecomment-347276268, or mute the thread https://github.com/notifications/unsubscribe-auth/ADVQwXo4hkIbJM1hxnq17Kxp8X1T0hm4ks5s6v4CgaJpZM4QZBVB .

mbiondi17 commented 5 years ago

I'd like to help out here if I can, but I also think it'd be useful to have a small reminder on the pop-up bar at the bottom of the equipment management page letting the user know if they're editing their equipped items or their costume.

current
paglias commented 5 years ago

what do you think @Tressley ?

Tressley commented 5 years ago

This is actually something that's been accounted for in the designs, but was not included in the initial post. When the user has the drawer collapsed, the active tab is displayed in the drawer header.

image

Alys commented 5 years ago

The work currently required for this issue is in progress [EDIT: no longer in progress; this issue is open for someone else to take up now], and once it's gone live we'll be able to tell from Tavern/guild posts whether it's helped enough to avoid the Costume vs Battle Gear confusion that players have. If there's still confusion, I'm guessing that more adjustments would be planned so I'm copying here a post that thebat137 (dea8a9e8-c084-438a-9a14-7fe96a73fd0a) made in the Report a Bug guild:

"By the way, I ran into another small issue just now when clicking on your chat icon to see the components of your lovely costume. The stats modal that displays shows your "Equipment" and your "Costume", and it wasn't immediately clear to me why your "Equipment" was the thing I can actually see you wearing, while your "Costume" was clearly not the thing I could see. I eventually realized that you must have both Equipment and a Costume configured, but with the "Use Costume" selector turned off. It seems like it would be nice if, when a user is doing this, the header and equipment piece labels for the "Costume" section of that modal were maybe grayed out and the header was changed to something like "Costume (Unused)" to make it a little more obvious what's going on."

Alys commented 5 years ago

I've removed some old comments that were just related to claiming this issue and getting access to Zeplin, just to make it easier for us to review the requirements. All technical and design comments are still present.

If anyone wants to claim this issue, post here and say what email address you'd like us to use for inviting you to Zeplin to see the design (if you don't want to make your email address public, you can tell us to use the address that's in your Habitica account and we can read it from there - just tell us your account's Username or User ID).

paglias commented 3 years ago

@Tressley is this something that we still want / have to implement?

Tressley commented 3 years ago

@paglias -- No. This issue can be closed. The work @negue has been doing on Inventory and Equipment accounts for the feedback in this issue.

On Sat, Oct 17, 2020 at 5:14 AM Matteo Pagliazzi notifications@github.com wrote:

@Tressley https://github.com/Tressley is this something that we still want / have to implement?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitica/issues/9458#issuecomment-710781438, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUP46WTALTQHH63MT7N3R3SLFN6FANCNFSM4EDECVAQ .