search

HachasyDados / HD-TCore

www.hachasydados.es
GNU General Public License v2.0
57 stars 24 forks source link

I greet you! #1

Open JasperAppec opened 13 years ago

JasperAppec commented 13 years ago

Hello there :)

Though I'd leave a fast suggestion and a thank for your great work. My suggestion would be if you could start committing in English instead of the current language. ^_^ (that would include the codelines as well)

And thanks for your work!

Souler commented 13 years ago

First of all, thank you for your comment. This encourage us to keep the hard work (at least for me :D).

And now, I'm trying as best as I can commiting in English, but only in the master branch, the others are for usually for dirty tests or patchs reworks, and there I prefer commitng in Spanish, if the changes finally work, the related commit at master branch will be in english. This is the way I'm doing it right now.

I've been writing line comments in C++ files in English for a while, but in SQL files I usually do it in spanish (not sure about the reason, but it's automatic XD).

Also take in account that we don't keep this repo as most of people do. We keep our commits at the top, rebasing them over the TrinityCore sources. And if an old commit needs a rewrite due to compile errors or for adding improvements we usually merge the changes on that commit, respecting the [HD XXX] order.

By my part, I'll try to write most things in english.

And thank you again!