search

Hack4Eugene / SpeedUpAmerica

Crowd-sourced internet speed tests using M-Lab data and user tests on a website, with charts, maps, and raw data downloads.
MIT License
25 stars 8 forks source link

Remove "all" from ISP field after removing previous filter (.5SP) #55

Open Amcclennahan opened 5 years ago

Amcclennahan commented 5 years ago

Steps to reproduce:

  1. Select and ISP
  2. Remove selection
  3. See behavior

SC attached -- In all instances where a filter is not selected we want to display the Select Client ISP to View sample text all liar

mattsayre commented 5 years ago

This one is about half way fixed. When you slick the X in the filter next to the word All, the map should not render and the filter field should say "Select an ISP".

khutchison commented 5 years ago

Is this still an issue? right now if you click x on All, it simply reloads the map and All remains.

I think either - "make All unremovable/don't reload the map when X is clicked on all" or Matt's proposed "stop the map from rendering and display 'Select an ISP' filler text" would work. Thoughts on which one creates a better UX?

alexandracorvello commented 4 years ago

I think having the default as All is the better user experience because visually it is more interactive from the start instead of being confronted with a blank map.

Another issue with the map is some typos: 1) as you can see in the screenshot above it the legend says "Download Speed", this should just say "Internet Speed" because you can view both upload and download speeds on the map.

2) When you group by Census Tract and click on a tract on the map, the label says "Tact" instead of "Tract".