Open eddiejaoude opened 8 years ago
So I've spent a fair few hours trying to get this to work, and keep getting stuck on installing everything needed for the ruby app. I'll push what work I've done, but to summarise it:
As it isn't critical to the delivery the project, I'm going to leave it and focus my efforts on the front end. Could possibly be helpful if someone else fancies taking a look. It's pretty much just the rails app that's causing the issues!
@cy0023 the shell script might be initially faster than a build tool like ansible on a new VM, but if re-provisioned it will be slower.
Its seems like a common issue on both situations. Has anyone else got the rails app running? Might have to pair with a Rails developer to debug.
So I'm a bit confused where we are with this, since we have both
mark/vagrant
branch which worked for me after updating from VirtualBox 5.0.x to 5.1.y.I'm definitely in favour of getting a Vagrant environment working which automatically sets everything up, ideally without unnecessarily chucking away any good work which was put into both of the above approaches. Bonus points for wrapping each individual service in a Dockerized microservice, but I agree that's low priority for now. I could try to fix the Ruby issue with #51 but first need to understand which of the two approaches we should be targetting; can we merge them into one?
So I'm a bit confused where we are with this, since we have both
Me too, I wasn't aware of the other branch.
I'm definitely in favour of getting a Vagrant environment working which automatically sets everything up, ideally without unnecessarily chucking away any good work
Yep 👍
It looks like the mark/vagrant branch focuses on setting up javascript. Where PR #51 is looking at the platform as a whole, to contain all dependent services (e.g. python, ruby, php, postgres etc). I think they could be merged.
As #51 contains the majority of the platform, I would suggest getting Ruby project working on there & bringing the javascript specific work in - also I have ansible scripts from another project for node & npm, so this should be straight forward & that way we avoid custom shell scripts. The Ruby project is still the blocker on PR #51, @JohnSmall is doing the Ruby part and will be able to help.
Sounds good to me
On 17 Nov 2016 07:45, "Eddie Jaoude" notifications@github.com wrote:
So I'm a bit confused where we are with this, since we have both
Me too, I wasn't aware of the other branch.
I'm definitely in favour of getting a Vagrant environment working which automatically sets everything up, ideally without unnecessarily chucking away any good work
Yep 👍 Suggestion
It looks like the mark/vagrant branch https://github.com/HackBrexit/MinistersUnderTheInfluence/compare/mark/vagrant focuses on setting up javascript. Where PR #51 https://github.com/HackBrexit/MinistersUnderTheInfluence/pull/51 is looking at the platform as a whole, to contain all dependent services (e.g. python, ruby, php, postgres etc). I think they could be merged. Next Step
As #51 https://github.com/HackBrexit/MinistersUnderTheInfluence/pull/51 contains the majority of the platform, I would suggest getting Ruby project working on there & bringing the javascript specific work in - also I have ansible scripts from another project for node & npm, so this should be straight forward & that way we avoid custom shell scripts. The Ruby project is still the blocker on PR #51 https://github.com/HackBrexit/MinistersUnderTheInfluence/pull/51, @JohnSmall https://github.com/JohnSmall is doing the Ruby part and will be able to help.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/HackBrexit/MinistersUnderTheInfluence/issues/46#issuecomment-261177451, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgQQv9F4y4uPEglNsiyW--ZgiWtBkPpks5q_AYAgaJpZM4KPMXM .
@aspiers can I close this?
@charlottebrf No this is still very much WIP.