Preloader added - Githubissues

HackClubRAIT / HackClubRAIT.github.io

Website for hackclub rait

https://hackclubrait.github.io/

MIT License

20 stars 56 forks source link

Preloader added #117

Closed sorba160 closed 2 years ago

sorba160 commented 2 years ago

What is the change?

I added a pre loader to the website.

Related issue?

closes: Add Preloader #105

Checklist:

Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] I have followed the Code of Conduct.
[x ] I have checked there aren't other open Pull Requests for the same update/change.
[ x] I have you tested the code before submission.
[x ] I have commented my code, particularly in hard-to-understand areas.
[x ] My changes generates no new warnings.
[ x] I'm JWOC contributor.

Screenshots (if any)

sorba160 commented 2 years ago

Pull request was unfortunately closed due to some technical problem, So I have re created it , and I think there is no need to create branch because I am working forking it to my account , so already I can have my code separately . @Chaitalishetty

Chaitalishetty commented 2 years ago

Okay fine ! But do make the necessary changes that I suggested

sorba160 commented 2 years ago

@Chaitalishetty I updated the pre loader .

Chaitalishetty commented 2 years ago

Can you resolve the merge conflicts?

sorba160 commented 2 years ago

Can you resolve the merge conflicts?

@Chaitalishetty yeah I have resolved the conflict. Now you can merge it.

Chaitalishetty commented 2 years ago

Not able to see the preloader.

sorba160 commented 2 years ago

Not able to see the preloader.

I have updated the preloader. I think this is the website is very fast so the preloader is not clearly visible. You configure the network to fast or slow 3G after inspecting you can clearly see it.