search

HackForEquality / android-app

An Android application created by the HackForEquality
MIT License
1 stars 9 forks source link

It is possible to swipe the badges off the camera screen #15

Closed canuckjacq closed 9 years ago

canuckjacq commented 9 years ago

Can we restrict the badges to the confines of the camera display area?

josmas commented 9 years ago

you mean having the info pages in the same area as the camera? that's not how the iOS app looks like. What happens to the take picture button?

It's a big structural change; with the limited time we have, I'd rather finish functionality than changing stuff that is already there.

canuckjacq commented 9 years ago

Hi, I think I probably worded this badly. This isn't a design change but a bug with how the Yes Equality badges work on the camera interface. I'm on slack if you want to discuss it.

josmas commented 9 years ago

clarification: This has nothing to do with info pages; it's the badges used within the camera view. My mistake on reading this wrong!

canuckjacq commented 9 years ago

This is still happening. Is it possible to restrict them to the four corners of the preview?

Ankhwatcher commented 9 years ago

Addressed in https://github.com/HackForEquality/android-app/commit/73c1980c9e70e952e8b573b4acdda63b3f1cf2b5 by detecting when the badge would be obscured and repositioning it onto the camera view.