search

HackForEquality / android-app

An Android application created by the HackForEquality
MIT License
1 stars 9 forks source link

Camera aspect ratio/crop #4

Closed canuckjacq closed 9 years ago

canuckjacq commented 9 years ago

The camera is the main feature of the app, so this part needs to be pretty much flawless. At the moment, it's going to make people look wider than normal, so they may not want to take selfies ;)

canuckjacq commented 9 years ago

Camera is improved but now stretched tall instead of wide in viewfinder. The resulting image isn't the same crop as the viewfinder. See attached images. screenshot_2015-04-29-06-27-03 screenshot_2015-04-29-06-27-12

canuckjacq commented 9 years ago

This is almost perfect. Noticed that the sides of the saved image are tighter cropped than in the preview, often resulting in the badges being snipped at the edges for me.

canuckjacq commented 9 years ago

If we had all the time in the world, this could use some improvement, but for now, we'll have to leave it. :)