Have ability to have member field on users

HackGT / ground-truth

🛰 Single sign on for HackGT apps

https://login.hack.gt

MIT License

7 stars 2 forks source link

Have ability to have member field on users #35

Closed ayush-goyal closed 3 years ago

ayush-goyal commented 3 years ago

Closes #24

Adds member field to User type
Refactor api.ts file into multiple files in api folder (most of the functionality is the same, just split up)
Change admin api to follow proper REST format, (eg use PUT, DELETE when appropriate for modifying apps and scopes)
Change admin view to have a table and allow promote/demote users and adding members

evan10s commented 3 years ago

Won't be able to review the code until later this week, but from a usability standpoint, we need a way to mass add users as members when they may not have existing accounts. A unique link is probably easiest.

From a security standpoint, having some kind of automated expiration for users' members status (if they aren't an admin) at the end of the season + a grace period would be nice too.

ayush-goyal commented 3 years ago

Hmm Id be wary about creating a unique link in case they send it to anyone else and other people get promoted also and we wouldn't know. Automated expiration would be nice too, but also a lot of work to implement and I don't know if its worth it right now considering our small scale.

ayush-goyal commented 3 years ago

Just pushed a change allowing users to enter multiple emails at once