Closed mjkaufer closed 7 years ago
I think we should keep package-lock.json
it lets us know what package versions work with this app for sure.
@illegalprime isn't that what versioning in the package.json
is for?
@mjkaufer yeah it is, package.json
says what versions our app should work with but package-lock.json
shows us one combination of packages that worked for sure.
@illegalprime Sounds good, re-added it
Just to add another thing, for libraries package.json
should be ignored, since you want your library to work with all versions stated in your package.json
, for applications or binaries you should have a package-lock.json
UI bug before initial animation is complete - Apply Now
button overlaps with Skip...
@bunsenmcdubbs I think I fixed the skip bug
testing...
Is there no more intro sequence? I can't seem to find it (checked localStorage - nothing there - and still don't see any intro/skip button)
@bunsenmcdubbs I'm definitely getting it on my end - try it in an incognito window or something. If that still doesn't work, give me your browser details.
@mjkaufer the skip button and apply now are still overlapping when the window is large
@bunsenmcdubbs I'm not seeing anything like that on my end. Did you try re-bundling everything? Also, can you let me know screen resolution + browser + OS?
@mjkaufer add text-decoration: none;
Also mobile-optimized some text, and store whether or not user has seen 'init' message in localstorage
Should fix https://github.com/HackGT/hackgt4/issues/4