HackGT / hackgt4-website

Website for HackGT4
GNU General Public License v3.0
0 stars 0 forks source link

UX: Made apply button instantly visible #5

Closed mjkaufer closed 7 years ago

mjkaufer commented 7 years ago

Also mobile-optimized some text, and store whether or not user has seen 'init' message in localstorage

Should fix https://github.com/HackGT/hackgt4/issues/4

illegalprime commented 7 years ago

I think we should keep package-lock.json it lets us know what package versions work with this app for sure.

mjkaufer commented 7 years ago

@illegalprime isn't that what versioning in the package.json is for?

illegalprime commented 7 years ago

@mjkaufer yeah it is, package.json says what versions our app should work with but package-lock.json shows us one combination of packages that worked for sure.

mjkaufer commented 7 years ago

@illegalprime Sounds good, re-added it

illegalprime commented 7 years ago

Just to add another thing, for libraries package.json should be ignored, since you want your library to work with all versions stated in your package.json, for applications or binaries you should have a package-lock.json

bunsenmcdubbs commented 7 years ago

UI bug before initial animation is complete - Apply Now button overlaps with Skip... screen shot 2017-08-08 at 1 14 43 pm

mjkaufer commented 7 years ago

@bunsenmcdubbs I think I fixed the skip bug

illegalprime commented 7 years ago

testing...

bunsenmcdubbs commented 7 years ago

Is there no more intro sequence? I can't seem to find it (checked localStorage - nothing there - and still don't see any intro/skip button)

mjkaufer commented 7 years ago

@bunsenmcdubbs I'm definitely getting it on my end - try it in an incognito window or something. If that still doesn't work, give me your browser details.

bunsenmcdubbs commented 7 years ago

@mjkaufer the skip button and apply now are still overlapping when the window is large

mjkaufer commented 7 years ago

@bunsenmcdubbs I'm not seeing anything like that on my end. Did you try re-bundling everything? Also, can you let me know screen resolution + browser + OS?

illegalprime commented 7 years ago

@mjkaufer add text-decoration: none;