Closed petschekr closed 5 years ago
Hey y'all! A deployment of this PR can be found here: https://registration-fix-drop-downs.pr.hack.gt
Do we need to update questions.json
to drop please select, otherwise lgtm
@joel99 Yeah we have to remove the explicit "Please select" option from the Catalyst questions
Currently, the first choice is automatically selected by the user's browser. This PR adds a "Please select" option to the list which is selected by default but is marked with the
disabled
attribute (which browsers don't send along upon submission). The server side code will then catch this missing question and either mark the value asnull
(if the question is optional) or display an error to the client telling them which question they left blank.This PR also:
local
logins are the only login method defined in the settings (e.g. when using the new default from #256 )