HackGT / registration

Powerful and extensible registration system for hackathons and other large events
https://registration.hack.gt
MIT License
6 stars 1 forks source link

Logout is causing either application crash or noop #277

Closed emersonford closed 5 years ago

emersonford commented 5 years ago

Somewhere in the dependency tree, agent-base is imported and wraps around the request method of https. Due to https://github.com/TooTallNate/node-agent-base/issues/29, the code path for logout is using a signature of request that is out of sync with the signature in agent-base. This inevitably lead to the dropping of host and defaulting to localhost... as we are using Nginx for proxying and Cloudflare for SSL, we didn't have anything listening on localhost:443 and the whole registration application to crashed on each logout as the request error went unhandled. Even with handling, the logout request would become a noop as the logout call was never made to ground-truth.

Pull request #276 fixes the use of request to match the signature found in agent-base.