Fix `PUT /profile/` - Githubissues

HackIllinois / api

The Official API supporting HackIllinois

https://api.hackillinois.org

Other

23 stars 51 forks source link

Fix `PUT /profile/` #544

Closed Timothy-Gonzalez closed 1 year ago

Timothy-Gonzalez commented 1 year ago

Currently, all fields are required (except foodWave and points), just like POST, making this endpoint functionally useless. These fields should not be required for PUT. We should also add E2E tests for PUT so this doesn't happen again.

[ ] Fix PUT required fields
[ ] Add E2E tests for PUT

Timothy-Gonzalez commented 1 year ago

I confused PUT and PATCH, lol. Proper way is to GET then PUT.

There still probably should be a PATCH method, but we'll save that for when we rewrite the api in rust.