HackIllinois / api

The Official API supporting HackIllinois
https://api.hackillinois.org
Other
23 stars 51 forks source link

Registered user name does not get updated if Sparkpost fails #547

Open Nydauron opened 1 year ago

Nydauron commented 1 year ago

We hit Sparkpost monthly rate-limit, and that caused the entire registration endpoint to create partially handled responses un-atomically.

We need to wrap this (and a bunch of other endpoints in general) in transactions and move the nameless updating prior to attempting to send the confirmation email. https://github.com/HackIllinois/api/blob/12131516a49870f3da88e5a8046374edb9793978/services/registration/controller/controller.go#L170-L195