Bump up deployment target

HackIllinois / iOS

The Official iOS App of HackIllinois

University of Illinois/NCSA Open Source License

17 stars 10 forks source link

Bump up deployment target #586

Closed anushkasankaran closed 3 weeks ago

anushkasankaran commented 2 months ago

Fixes #585

Deployment target increase from iOS 14.0 to iOS 17.0.
Re-added url-image package to fix missing package dependencies.

AydanPirani commented 2 months ago

@anushkasankaran hmm, is build supposed to be failing?

lasyaneti commented 2 months ago

Does local build work? Error looks like an architecture issue but PR diff doesn't touch anything related to that.

anushkasankaran commented 2 months ago

Local build was working fine. It was kind of buggy though and I did something irrelevant to most of the build errors and it got rid of all of them.

s0phialiu commented 2 months ago

warning: None of the architectures in ARCHS (x86_64) are valid. Consider setting ARCHS to $(ARCHS_STANDARD) or updating it to include at least one value from VALID_ARCHS (arm64, arm64e, armv7, armv7s). (in target 'URLImage' from project 'URLImage')

Can you go to Project Settings in Xcode, go to build settings, and see if setting Architectures to $(ARCHS_STANDARD) does anything?
Can you try making a dummy PR with the non-bumped up version and see if there's still a build error?