HackMyChurch / aelf-dailyreadings

AELF daily readings is the easiest and most discrete daily reading application on the play store. https://play.google.com/store/apps/details?id=co.epitre.aelf_lectures
MIT License
46 stars 13 forks source link

Bible state restore, intent filter and share button #12

Closed yadutaf closed 5 years ago

yadutaf commented 5 years ago

Voici les améliorations suivantes pour la partie "Bible":

Je commence à regarder pour mettre en place une navigation via le bouton de retour en arrière (https://developer.android.com/training/implementing-navigation/temporal#java). C'est un peu moins simple à mettre en place que cela en a l'air car l'état semble perdu entre 2 actions.

Si cela te convient, je te laisse commenter et / ou merger :)

nathanael-h commented 5 years ago

bible: add intent filter

This is nice !

bible: add share button

This is nice ! :+1:

yadutaf commented 5 years ago

Hi ! Thanks for the review :). Regarding your comment on "bible: restore loaded page on application re-open", I agree with you. This commit only addresses one specific (but significant) use case. When Android kills an application to save memory, it first gives a chance to the application to save its state so that it may restore it later on. This can be tested by enabling the ad-hoc option in the debug settings of Android. Clearly, this commit does not address the navigation issue or the "back" navigation. This is something I'd like to work on in a later commit, but it requires more work :)

nathanael-h commented 5 years ago

Hi! Ok, I understand. Thanks for the details. Let's merge !