search

HackMyChurch / aelf-dailyreadings

AELF daily readings is the easiest and most discrete daily reading application on the play store. https://play.google.com/store/apps/details?id=co.epitre.aelf_lectures
MIT License
46 stars 13 forks source link

hide bible verse numbers from screen readers #25

Closed yadutaf closed 5 years ago

yadutaf commented 5 years ago

Screen readers read the all the visible text on the screen. They are typically used by visually impaired people to navigate in applications. To them, hearing the verse number in the middle of the reading feels strange according to multiple reports I received.

This commit batch fixes this issue by adding 'aria-hidden="true"' to all verses. This was done using this command:

find -name '*.html' -exec sed -i 's/class="verse_number"/\0 aria-hidden="true"/g' {} \;
nathanael-h commented 5 years ago

I am ok with this PR. We could have thought to do it before releasing stable version😉 , if I remember you've done the same for mass and daily readings. Thank you!