search

HackMyChurch / aelf-dailyreadings

AELF daily readings is the easiest and most discrete daily reading application on the play store. https://play.google.com/store/apps/details?id=co.epitre.aelf_lectures
MIT License
46 stars 13 forks source link

Add night mode toggle to menu #28

Closed yadutaf closed 5 years ago

yadutaf commented 5 years ago

The new night mode is hard to discover, hidden deep in the preference screens. Rather than making some advertising popup, we can move the theme toggle to the application menu.

At the same time, this PR enhances the theme transition with a cross-fade to make it nicer. As it turns out, the hard part in this case is not the fade itself but getting the application state to restore properly. This was done by 'recreate', but recreate does not support transitions.

nathanael-h commented 5 years ago

Very nice PR ! There is still the night mode option in settings. Is it useful ? Could we remove it from this list ? When we toggle the night mode in settings (not from the app menu) the view is recreated and we are not taken back to settings.

yadutaf commented 5 years ago

Good point. Removed.