add stub Bible v2 - Githubissues

HackMyChurch / aelf-dailyreadings

AELF daily readings is the easiest and most discrete daily reading application on the play store. https://play.google.com/store/apps/details?id=co.epitre.aelf_lectures

MIT License

47 stars 14 forks source link

add stub Bible v2 #31

Closed yadutaf closed 5 years ago

yadutaf commented 5 years ago

We now have Bible section. This update was one of the most praised in the application history! We want to take it to next level and allow for early feedback without breaking the main features.

This commit introduces a "clean-sheet" new section to experiment with a new way to integrate the Bible in the application.

This new section is hidden behind a 'secret' tester option to limit the impact on existing users.

nathanael-h commented 5 years ago

I skimmed the modifications, this is a significant job you've done ! I can't understand the purpose of every bit of this code. Nevertheless it looks clean, it works on your tablet and on my phone, so I merge the PR. [Edit] : I remember something : it could be nice to have the Hebrew psalms numbers from 9B (Heb. 10) to 147 (Heb.147B)

yadutaf commented 5 years ago

I Like your proposition for the psalms numbering, inluding adding the "heb." prefix. Could you give me the full correspondance between AELF's psalm names and what should be displayed ? I'm not an expert of this and I'd rather avoid making a mistake.

No emergency on this area though, there is still a LOT of work !

yadutaf commented 5 years ago

Changes:

Fixed crash on restore bible state
Add "ripple effect" on click (nothing more :))

Known Issue:

The active table (At/NT/Psaumes) is not restored.

nathanael-h commented 5 years ago

For the psalms, you can find here infos for numeration : https://fr.wikipedia.org/wiki/Livre_des_Psaumes#D%C3%A9coupage_et_num%C3%A9rotation is enough for you ? I'll test your last commit soon.

yadutaf commented 5 years ago

The code is starting to look pretty good from my point of view. I'd like to merge it to get some feedback from early testers.

Here is the current state of things:

The refactored Bible replaces the current implementation, but only when a specific preference is enabled (off by default)
The theme is a cleaned version of the office theme so that it looks clean. In a future PR, the office code should be shared with this one.
Share support is implemented
Opening a link is implemented

There is still work on performance / hebrew pslam number support (I'd appreciate help)