HackMyChurch / aelf-dailyreadings

AELF daily readings is the easiest and most discrete daily reading application on the play store. https://play.google.com/store/apps/details?id=co.epitre.aelf_lectures
MIT License
47 stars 14 forks source link

Add support for themed icons #47

Closed ascpial closed 1 year ago

ascpial commented 1 year ago

With android 13 comes the ability for apps to set a monochrome icon that will be synced with the user theme.

For now, the AELF android app is missing support for these icons:

Screenshot_20230601-155209

nathanael-h commented 1 year ago

Actually I'm focused on the iOS app, that should be one day the Android app also...

But this icon studd might not be a big change. I could try to add this if @yadutaf would agree.

Nathanaël decouvrir-dieu.com isidorus.fr Cloud dégooglisé pour la famille et les amis

1 juin 2023 15:54:13 ascpial @.***>:

With android 13 comes the ability for apps to set a monochrome icon that will be synced with the user theme.

For now, the AELF android app is missing support for these icons:

[https://user-images.githubusercontent.com/72463129/242619330-ccec4038-3fac-4fd7-b170-b00f3119e6eb.png][Screenshot_20230601-155209][https://user-images.githubusercontent.com/72463129/242619330-ccec4038-3fac-4fd7-b170-b00f3119e6eb.png][https://user-images.githubusercontent.com/72463129/242619330-ccec4038-3fac-4fd7-b170-b00f3119e6eb.png]

— Reply to this email directly, view it on GitHub[https://github.com/HackMyChurch/aelf-dailyreadings/issues/47], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABXWJVM7Y3BVTCX42TZRKSLXJCNIHANCNFSM6AAAAAAYW62354]. You are receiving this because you are subscribed to this thread.[Image de pistage][https://github.com/notifications/beacon/ABXWJVOFMDV7K6FHFMW52STXJCNIHA5CNFSM6AAAAAAYW62356WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHGO7YVWI.gif]

yadutaf commented 1 year ago

Of course @nathanael-h ! Maybe I can at least do the chores of updating the various dependencies / SDK

yadutaf commented 1 year ago

I gave it a try locally, here is a preview:

image

nathanael-h commented 1 year ago

Cool :+1:

yadutaf commented 1 year ago

Just sent 2.8.0 to beta channel, with this fix. Closing.