search

HackNC / fall2024

0 stars 0 forks source link

Meet the team #13

Open vvkash opened 5 days ago

vvkash commented 5 days ago

Added Meet The Team page and Link to it in the nav bar, also changed the file location.

Had to make another pull request, the other one was having issues lol

aryasalian commented 1 day ago

I went over your code and fixed what rishi had asked for. There are still some issues with it and I tried fixing it as much as possible but I'll let you take over it again now. I noticed the slider would go way beyond where it's supposed to end so I tried to make some edits to your slider. There is a considerable amount of improvement but I need you to look into why the transformX isn't working accurately at different window sizes. It sometimes cuts the images or overshoots the scroll even though I've tried reducing that issue as much as possible. Focus on the line that causes the scroll, it's to do with the math of it.

vvkash commented 1 day ago

Yeah i see, i totally mislooked that haha. im refactoring right now and i think i got the issue where it overshoots and the issue with different window sizes. though for some reason the updated code wont allow me to click the arrows to scroll through, ive checked the event listeners as well. If its okay with everyone, i can implement all the changes you've done and the new updates to the sizing and issues but keep some of the arrow functionality and then commit again? lmk if this works and ill get it done and commit it this week!

vvkash commented 1 day ago

Also just to make sure, you want to keep the picture sizing the same even when the window itself is being changed right? also is there a certain sizing guide you want me to impliment and follow for the slider? Thanks!

aryasalian commented 18 hours ago

For the arrow functionality, it works as it is supposed to when I put my commits in...it is not supposed to scroll ahead if the last image in the slider is visible and at a normal window size, since we only have 3 images in the slider currently, the third image is visible in the slider by default so it seems that the arrow doesn't work but if you try and shrink the window to only keep one or two or even two and a fraction image visible, the scrolling functionality will work. It's the math of how many times should you be allowed to click the arrow for scrolling to the end is what needs to be fixed because as I said, when I was working with it, it either overshot it or didn't let you scroll enough.

As for the image size I think it is smart to have the image shrink to scale with window size since that would make all this much easier and we can instead just code each slider's arrow to be allowed to be clicked a fixed number of times instead of making it dependent on the no. of visible images/total images in the slider. Ensure that after a certain small window size, the slider just disappears entirely since having super tiny images wouldn't help anyways

aryasalian commented 18 hours ago

Good work on most of the stuff tho!