HackRU / lcs

The backend for HackRU's website. Manages the user system.
http://hackru.org
MIT License
6 stars 5 forks source link

Reduce/Remove usages of import * #114

Closed Kironb closed 2 years ago

Kironb commented 4 years ago

Some of our lambdas are reliant on importing all other imports for their functionality.

For example, maglink (https://github.com/HackRU/lcs/blob/e125485a05c94d13ad343c0ad2165d9190cf1be2/maglink.py) uses from schemas import *. At some point in time datetime.now() was used but never actually imported in the maglink file, but it was imported from schemas.py so it still works.

This can make it hard for people to track down import issues in the future and lead to other types of conflicts.

Ideally, we can reduce/remove every usage of import and replace it with the actual functions we need or the actual module name (so instead of from datetime import we use import datetime or from datetime import now)