search

HackRU / lcs

The backend for HackRU's website. Manages the user system.
http://hackru.org
MIT License
6 stars 5 forks source link

Slack dm endpoint #97

Closed Anarav closed 4 years ago

Anarav commented 4 years ago

It seems to be failing because it doesn't like me accessing the requests' LookupDict for the status code OK (200). Easy fix is just replacing that with the explicit number 200, but going to wait and see if anyone knows why this might be occurring in the first place (since it's a valid access and works locally with the given version of requests library)

Kironb commented 4 years ago

It looks like it could possibly just be a pylint error. It looks like they have had this error in the past (https://github.com/PyCQA/pylint/issues/1411) and I am not sure if it was ever resolved. It looks like it is due to requests setting codes using setattr (https://github.com/psf/requests/blob/master/requests/status_codes.py) which causes pylint to throw an error (https://stackoverflow.com/questions/35990313/avoid-pylint-warning-e1101-instance-of-has-no-member-for-class-with-dyn). We could just avoid using requests.codes.OK for now unless someone else has a different solution.

Anarav commented 4 years ago

Look's like slack token needs to be added. I have the token but it looks like an admin will need to add it to Travis. Relevant reference: https://docs.travis-ci.com/user/encryption-keys/