search

HackSoc / hacksoc.org

HackSoc website
https://www.hacksoc.org
8 stars 17 forks source link

URLs in calendar event descriptions aren't linkified #104

Open AaronC81 opened 4 years ago

AaronC81 commented 4 years ago

If a calendar event description contains a URL, it isn't converted into a clickable link by the calendar on the home page. This is a regression from Google Calendar's embed.

LukeMoll commented 3 years ago

@AaronC81 this appears to be fixed in the live version of the website, can you confirm? Also do you know which commit fixed this?

AaronC81 commented 3 years ago

This particular issue isn't fixed yet. The home-page calendar does respect HTML formatting, so if an event description contains an <a> tag then it'll be clickable on the site. But if it just contains a plain-text unformatted link, Google Calendar shows this as a clickable link, but our embed won't.

LukeMoll commented 3 years ago

Ah noted, thanks for the update.

JMAlego commented 3 years ago

Would this not be better solved in https://github.com/HackSoc/calendar-api given it can use a ruby library to do this in the middle, less work for the client etc.?