search

HackSoc / hacksoc.org

HackSoc website
https://www.hacksoc.org
8 stars 17 forks source link

No pip-requirements.txt #189

Open JMAlego opened 3 years ago

JMAlego commented 3 years ago

init-venv.sh tries to install pip requirements from the file pip-requirements.txt which doesn't exist.

JMAlego commented 3 years ago

Did you have a local one @LukeMoll that wasn't committed?

LukeMoll commented 3 years ago

No, I think it's leftover from before the hacksoc_org package was created and dependencies moved to setup.cfg. It should probably be deleted so the installation experience is uniform across platforms - I don't think the docs even refer to it still.

JMAlego commented 3 years ago

No, I think it's leftover from before the hacksoc_org package was created and dependencies moved to setup.cfg. It should probably be deleted so the installation experience is uniform across platforms - I don't think the docs even refer to it still.

When you say deleted do you mean the file or the line in the file?

LukeMoll commented 3 years ago

Sorry, I meant that init-venv.sh could probably be deleted. Unless people think that it would significantly lower barrier of entry vs copy-pasting the commands in the README, I think getting rid of it will make it easier to troubleshoot newcomers' problems. If we were to keep it then someone should write an equivalent file for Windows.

On Wed, 3 Nov 2021, 10:52 pm Jacob Allen, @.***> wrote:

No, I think it's leftover from before the hacksoc_org package was created and dependencies moved to setup.cfg. It should probably be deleted so the installation experience is uniform across platforms - I don't think the docs even refer to it still.

When you say deleted do you mean the file or the line in the file?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HackSoc/hacksoc.org/issues/189#issuecomment-960258563, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2N5U5BCIAJJ7TQ4IVEOG3UKG4KPANCNFSM5HKB5HZQ .