Feature/loader component

[senner008]

@humayunadilshahzad If no new packages are introduced then package-lock should not be committed either

[humayunadilshahzad]

Hi Niels .. actually my storybook was not running I did new pull and did npm install ... which modified package-lock.json .. thats y i commited it .. Is it not needed to commit ?

[senner008]

No you should not commit it. You need to run your install using the one from develop

[senner008]

You can try to undo your commits or create a new branch

[humayunadilshahzad]

thats what I was thing ... can I remove a specific commit or it has to be in reverse order .. I guess I can undo any commit .. yes ?

[senner008]

https://stackoverflow.com/questions/22682870/git-undo-pushed-commits

[senner008]

Alternatively just overwrite your package-lock with the one from develop and push that commit

[humayunadilshahzad]

Niels I have reverted it locally . I did " git revert 0184a40c7fabd951c94c5f789302f032d0f0f09d " it says [feature/loader-component 96d2f6d] Revert "packages updated" 1 file changed, 69 insertions(+), 23 deletions(-) .. documentation says .. revert commit ... is a new commit .. do I need to push it again ?

[senner008]

Yes, push the commit

[senner008]

That did the trick 👍

[humayunadilshahzad]

Thanx Niels

[cecastosic]

Great job @humayunadilshahzad 💪

[senner007]

@cecastosic @humayunadilshahzad Is it ready for merge?

[humayunadilshahzad]

Thanx .. @cecastosic .. @senner007 and Yes I hope so its complete .