HackYourFuture-CPH / Guide-IT

Guide IT, a tool to help newcomers decide their IT path

MIT License

3 stars 1 forks source link

Drop foreign keys for tables to fix heroku build #135

Closed sofiiadidovych closed 3 years ago

sofiiadidovych commented 3 years ago

Description

We changed migration files in order to remove foreign keys, to allow drop tables while seeding process. Also, seeds file for questions was changed. In order to populate question table we need to delete all info from the answers table, and only then we can actually delete info from questions table and insert the new info. This should fix error on Heroku.

Fixes # 132

How to test?

Heroku build should be successful

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] This PR is ready to be merged and not breaking any other functionality

sofiiadidovych commented 3 years ago

it looks great, just next time push the files that been changes 👍

@abedaarabi Thank you for the review. What do you mean "next time push the files that been changes"? I think I only pushed the 4 files I changed.