HackYourFuture-CPH / Guide-IT

Guide IT, a tool to help newcomers decide their IT path

MIT License

3 stars 1 forks source link

I have added all the routes for missing pages #140

Closed JyothiNandyala closed 3 years ago

JyothiNandyala commented 3 years ago

Description

I have added all the routes for the missing pages in app.js file.

Fixes # (issue)

118 How to test?

give the command like npm run dev then check all the pages with /(link name).

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] This PR is ready to be merged and not breaking any other functionality

Enqira commented 3 years ago

Well done Jyothi, but shouldn't you use AuthenticatedRoute instead of Route for the protected routes, because for instance we don't want the client to be able to access career-page, results profile-page, elevator-pitch, etc if they are not authentificated? Am I wrong?