HackYourFuture-CPH / Guide-IT

Guide IT, a tool to help newcomers decide their IT path

MIT License

3 stars 1 forks source link

changed some styling in different files for the homepage #222

Closed TITHI1244 closed 3 years ago

TITHI1244 commented 3 years ago

Description

changed some styling in different files for the homepage

Fixes # (issue)

The homepage was not one-page, needed to scroll down
Missing text-shadow for the app heading
Missing buttons shadow

How to test?

Please provide a short summary how your changes can be tested?

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] This PR is ready to be merged and not breaking any other functionality

DlnyaMazhari commented 3 years ago

homepage

thanks @TITHI1244 but few things to mention : box sizes don't match

DlnyaMazhari commented 3 years ago

homepagee

In here, the font is very small.

DlnyaMazhari commented 3 years ago

1920x1080

and in size 1920 x 1080 , the font sizes are very small

TITHI1244 commented 3 years ago

thanks @TITHI1244 but few things to mention : box sizes don't match

Yes, that I saw but ignored. Don't have much time now. Need to fix a few more pages. Actually it's taking long time as it involves many pages and there are lots of fixed styling here and there, in px. Will try to fix it if I can manage others. Thanks.

TITHI1244 commented 3 years ago

Closing this PR as I did it in a rush and it was incomplete.