HackYourFuture-CPH / Guide-IT

Guide IT, a tool to help newcomers decide their IT path
MIT License
3 stars 1 forks source link

Fixed next step page stylings #232

Closed sandhana14 closed 3 years ago

sandhana14 commented 3 years ago

Description

Fixed next step page stylings

Fixes # (issue)

228

How to test?

npm run dev

Checklist

sandhana14 commented 3 years ago

Try to be consistent with the units you use, you can read more about units in MDN. Overall it is best to use relative units rather than absolute units. Try to keep consistency for the things that serve the same purpose, so fx. distances, widths, font-sizes etc.

The top and left properties and translate one serve a similar purpose, so you are moving the elements in the X and Y direction with both properties, plus in some cases, you add an extra distance with the margin. Do you need to do this?

On line 60 and 61 an image is being modified on width and height, just choose one. It is best practice, otherwise you might end up distorting the image.

Hi Valentina, Thank you so much for your review. What you have mentioned, I also agree with you. If I have to consider all these changes, I have to change most of the next step page CSS. For that, I have to discuss with the person who actually did the whole page. Because Currently I changed only the button styles and gave some responsiveness. Please kindly let me know What should I do now?