HackYourFuture-CPH / chattie

Chattie is an app for messaging with your collegaues
MIT License
0 stars 4 forks source link

Fix send/empty/message #307

Closed STEP0HEN closed 3 years ago

STEP0HEN commented 3 years ago

Description

This PR fixes a bug on sending an empty string in the message field, it also makes correction to documentation in patch, post and get messages by id endpoint. Fixes # (issue) N/A

How to test?

You can test sending empty string at http://localhost:3000/api/documentation/#/default/post_messages and the patch at http://localhost:3000/api/documentation/#/default/patch_messages__ID_ and get by id at http://localhost:3000/api/documentation/#/default/get_messages__ID_ in all in swagger or postman at localhost:5000/api/messages

Checklist

STEP0HEN commented 3 years ago

Hi Victoria, thanks for the review. I don't think I understand what you mean by change the post createMessage can you check the files change link files changed link and give inline comments I think that'll be easier. Thank you again

panivita commented 3 years ago

Stephen sorry, all ok. I delete my previous comment. It is very good that you fixed createMessage , editMessage and especially swagger , now we can test that in swagger documentation.