HackYourFuture-CPH / fp-class12

Treasure Hunt Game for children

MIT License

5 stars 3 forks source link

Storybook deployment on Netlify #182

Closed JohnYazji closed 4 years ago

JohnYazji commented 4 years ago

Description

Please provide a short summary explaining what this PR is about.

Deploy storybook stories of fp-class12 on Netlify

Fixes #178

How to test?

https://storybook-fp-class12.netlify.app/?path=/story/*

Please provide a short summary how your changes can be tested?

Checklist

[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] I have merged the latest version of the source branch (typically develop) into this branch before pushing my changes
[ ] This PR is ready to be merged and not breaking any other functionality

zkwsk commented 4 years ago

I don't know what is wrong and don't quite have the time to debug this further, but I can reproduce the error locally if I build storybook and try to serve it out of the /storybook-static folder.

Two small things:

Could you change this to a draft PR?
I would prefer if you work directly on the main repo rather than on your own fork. To checkout your code I either need to checkout your fork separately or add it as a remote and that's a bit tedious with many contributors.

JohnYazji commented 4 years ago

I don't know what is wrong and don't quite have the time to debug this further, but I can reproduce the error locally if I build storybook and try to serve it out of the /storybook-static folder.

Two small things:

Could you change this to a draft PR?

I would prefer if you work directly on the main repo rather than on your own fork. To checkout your code I either need to checkout your fork separately or add it as a remote and that's a bit tedious with many contributors.

JohnYazji commented 4 years ago

I closed this PR because I have created a new PR #187