HackYourFuture-CPH / fp-class18

Interior design webshop
MIT License
1 stars 0 forks source link

guest user and logged in user handling on cart page #251

Closed varsha84 closed 2 years ago

varsha84 commented 2 years ago

Description

This PR fixes:

  1. Delivery Form and Contact Form render based on auth (logged in user Vs guest) --> Fixed
  2. TotalPrice Component always shows delivery charges when no item in cart --> Fixed
  3. when Cart is Empty, Cart page will render message "your Cart is Empty"
  4. CSS on Contact Form and Delivery Info -> Fixed
  5. Cart page CSS align as per wireframe.
  6. add/remove to favorite form shopping cart -> fixed
  7. guest user click on favorite icon -> does not do anything

This PR must be merge after PR #245

Fixes #246 #253

How to test?

npm run dev got to http://localhost:3000/cart/ please clear your localStorage before testing by running localStorage.clear(); in your console

test with logged in user

test without logged in

Checklist

BikramRawat commented 2 years ago

Also need to work on Responsiveness of the page.

varsha84 commented 2 years ago

if you are linking to cart page. Please give the right path to access cart page.

varsha84 commented 2 years ago

If we dont need the user id : need to remove from the menu path for this cart icon.

to: - Accepted. will remove the id from cart link
varsha84 commented 2 years ago

Hi Varsha Really good job πŸ‘. I approved this PR. Just I want one things from you. Can you add .cart-page front of every CSS classes from cartPage.style.css? Simon was talked about that and still working about this CSS changes. Thank you

Done πŸ‘

varsha84 commented 2 years ago

Its working fine. Just need to remove the id part from its path on the Menu component.

done πŸ‘

varsha84 commented 2 years ago

Thanks to all for reviewing and approve this PR πŸ‘