search

HackYourFuture-CPH / fp-class18

Interior design webshop
MIT License
1 stars 0 forks source link

Bug : Remove review button when shopping cart empty and order review button should redirect user to login #272

Closed semih1239 closed 2 years ago

semih1239 commented 2 years ago

User story

Who: As a developer What: I want to be remove 'review order' button if shopping cart is empty and if user is not login review button will send user to login. Why: so that user can't click this button when cart is empty and user login check

Acceptance criteria

If shopping cart is empty then review order button should be disappear. If user is not login and want to review order then order review button should redirect user for login. image

dpfernandes commented 2 years ago

I agree that the user should NOT BE ABLE to review but we should have a way to REDIRECT the user to the login

@semih1239 what do you think?

semih1239 commented 2 years ago

I agree that the user should NOT BE ABLE to review but we should have a way to REDIRECT the user to the login

@semih1239 what do you think?

I think we can add an option in review order button. If shopping cart has an item and user want to buy so we can route user for login. I can open another issue or I can update this issue. Which one is better?

Edit: I updated this issue.

dpfernandes commented 2 years ago

@semih1239 You can go with the route to login.

semih1239 commented 2 years ago

@semih1239 You can go with the route to login.

@dpfernandes I updated PR already 👍