HackYourFuture-CPH / fp-class18

Interior design webshop
MIT License
1 stars 0 forks source link

FrontEnd/Bug: Home button on Menu And Go Home button Bug #282

Closed simonreddy2001 closed 2 years ago

simonreddy2001 commented 2 years ago

Description

This PR add a Home button on menu and GoHome button not to refresh Please provide a short summary explaining what this PR is about.

Fixes #278

How to test?

npm run dev check all goHome buttons which dont refresh There is a Home button on Menu bar Please provide a short summary how your changes can be tested?

Checklist

simonreddy2001 commented 2 years ago

Hi @simonreddy2001 Home button looks okay and its working, but i found an issue: when i click on monthly arrivals or on about menu, its not working, fx: when I click on About menu on landing page, its not navigating to the about page instead its clicking to Home page, and same issue with the monthly arrivals.

Yes its beacause of margin... fixed it ..

simonreddy2001 commented 2 years ago

Hi Simon I checked it is working perfectly. But Homepage icon is affecting shopping cart icon counter. Can you make some changes on menu CSS? You can change just header .badge{ right : 8em;}

Done

netlify[bot] commented 2 years ago

✔️ Deploy Preview for class18-fp-storybook ready!

🔨 Explore the source changes: e78e9a893ccf70e52c67f8ab324e4ae064157fd3

🔍 Inspect the deploy log: https://app.netlify.com/sites/class18-fp-storybook/deploys/61b9c462fc53c90007b0b44d

😎 Browse the preview: https://deploy-preview-282--class18-fp-storybook.netlify.app