simonreddy2001 commented 2 years ago

Description

This PR will remove heart if you are not logged in Please provide a short summary explaining what this PR is about.

Fixes #270

How to test?

npm run dev check logged in and logged out Please provide a short summary how your changes can be tested?

Checklist

[x] I have performed a self-review of my own code
[x] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
[x] I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
[x] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
[x] This PR is ready to be merged and not breaking any other functionality

OlenaKasian commented 2 years ago

Don`t merge without my approve

simonreddy2001 commented 2 years ago

Don`t merge without my approve

Okay ..sure

simonreddy2001 commented 2 years ago

Everything works fine 👍 But i found one issue. When user is logged in , and goes to any categories fx, Furniture and click on any product. After that if you chose the product as favorite, then all the similar products will be labelled as favorites, even though they all are not added to the favorite page which is good part. The only issue is: When you choose any product of any category as favorite, then it labels all the similar products as favorite. So need to fix this issue. And, when the use is not logged in the favorite icon (heart symbol) is removed from the products and also from the Menu bar 👍 , So its working perfectly fine when the user is not logged in.

This is already have another issue 271... Jai fixed this i think

BikramRawat commented 2 years ago

👍

simonreddy2001 commented 2 years ago

Hi Simon, When i am logout and try to add item in shopping cart then shopping cart counter appears at the old position

Fixed ..Thanks for heads up

HackYourFuture-CPH / fp-class18

FrontEnd: Removed heart if you are not logged in on Menu, Monthly Arrivals and Product Page #289

Description

How to test?

Checklist