Closed dpfernandes closed 2 years ago
Hi Daniel, I got comments on my PR from @BikramRawat, about naming conventions. that does not fully align with this issue file naming conventions.
https://github.com/HackYourFuture-CPH/fp-class18/pull/33
/MotorcycleCard/MotorcycleCard.component.js (for component file) /MotorcycleCard/MotorcycleCard.styles.css (for CSS file) /MotorcycleCard/MotorcycleCard.stories.js (for stories file)
but I changed in my PR as per the review comments
User story
Who: As a developer What: I want to develop the App's pages in placeholders even though all the components are not ready. Why: So that we can get some work done with those components that are ready to be used in those placeholders.
Acceptance criteria
Create Dummy pages and css files for those pages:
LandingPage- src/client/containers/LandingPage/LandingPage.Container.js
LandingPage.Style- src/client/containers/LandingPage/LandingPage.Style.css
ProductPage - src/client/containers/ProductPage/ProductPage.Container.js
ProductPage.Style - src/client/containers/ProductPage/ProductPage.Style.css
CategoryPage - src/client/containers/CategoryPage/CategoryPage.Container.js
CategoryPage.Style - src/client/containers/CategoryPage/CategoryPage.Style.css
MonthlyArrivalsPage - src/client/containers/MonthlyArrivalsPage/MonthlyArrivalsPage.Container.js
MonthlyArrivalsPage.Style - src/client/containers/MonthlyArrivalsPage/MonthlyArrivalsPage.Style.css
FavoritesPage - src/client/containers/FavoritesPage/FavoritesPage.Container.js
FavoritesPage.Style - src/client/containers/FavoritesPage/FavoritesPage.Style.css
CartPage - src/client/containers/CartPage/CartPage.Container.js
CartPage - src/client/containers/CartPage/CartPage.Style.css
OrderPage - src/client/containers/OrderPage/OrderPage.Container.js
OrderPage - src/client/containers/OrderPage/OrderPage.Style.css
ConfirmationPage - src/client/containers/ConfirmationPage/ConfirmationPage.Container.js
ConfirmationPage - src/client/containers/ConfirmationPage/ConfirmationPage.Style.css
ProfilePage- src/client/containers/ProfilePage/ProfilePage.Container.js
ProfilePage.Style - src/client/containers/ProfilePage/ProfilePage.Style.css
404Page - src/client/containers/404Page/404Page.Container.js
404Page.Style - src/client/containers/404Page/404Page.Style.css
At this point these files will be used as placeholders so that everyone knows where place the components that belong to each page.
Please only write the page tile for example
Implemented details
Please make sure the pages don't exist with a different name so we avoid duplicates.