search

HackYourFuture-CPH / node.js

NodeJS - Fullstack development
6 stars 52 forks source link

broken image #51

Closed sofiiadidovych closed 3 years ago

sofiiadidovych commented 3 years ago

in the 'Getting data through the request body using POST' section there should be a screenshot with some setup, but the page is not found: https://github.com/HackYourFuture-CPH/node.js/blob/master/assets/calculator-post.PNG

nkuik commented 3 years ago

Hi @sofiiadidovych. Thanks for creating this issue.

I was wondering if you had any interest in making a fix for this. The image the link thought it's referring to is located here. To make a fix, you could:

  1. Move the calculator-post.PNG file to the assets directory in the repo base (the directory can be found here).
  2. Change the reference in the week 3 homework readme to make a relative reference to the calculator-post.PNG that moved in step 1. You can read about relative references in GitHub repos here.

Let me know what you think.

sofiiadidovych commented 3 years ago

Hi @nkuik! I will do it with pleasure, but I have a question: do I need to make this change locally and then make a pull request, and then it will be merged to master?

nkuik commented 3 years ago

Great! Since you don't have write access to this repo (which is intentional), you will need to make a PR across forks. This means you will need to fork this repo, make the change, and then open a PR back to this repo.

You can read about forking repos here, and about making a PR across repos here.

Just let me know if you have any questions. Thanks for the help!

sofiiadidovych commented 3 years ago

@nkuik everything is done, my PR is here https://github.com/HackYourFuture-CPH/node.js/pull/52 Hope everything works ok)