arya56 commented 3 years ago

Description

regarding issuer#117 Please provide a short summary explaining what this PR is about. screen shot before

Fixes # (issue)

117 How to test?

Screen shot after

if you check those two page shouldn't been seen any footer there Please provide a short summary how your changes can be tested? check this url http://localhost:3000/sign-in

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] This PR is ready to be merged and not breaking any other functionality

dpfernandes commented 3 years ago

Please consider issues #122 and #123 for this.

arya56 commented 3 years ago

I think this issue is related to the footer task. Shouldn't have been done within that task?

arya56 commented 3 years ago

Since I have done it & will be applied to both of issues #122 and #123 . I think it's reasonable for the sake of not doing double job.

pdsorensen commented 3 years ago

@arya56 merge it with develop and i think you can merge it yourself.

HackYourFuture-CPH / rate-my-cv

no footer for sign-up & sign-in #118

Description

117

How to test?

Checklist