HackYourFuture-CPH / rate-my-cv

MIT License
1 stars 2 forks source link

Signup userform Component with password validation #131

Closed kamalrsa closed 3 years ago

kamalrsa commented 3 years ago

Description

Signup form password must be match the pattern is: Must contain at least one number and one uppercase and lowercase letter, and at least 6 or more characters"

**Footer should be remove or fixed in buttom***

Fixes # 42

How to test?

screencapture-localhost-3000-sign-up-2021-02-08-18_03_48 (1)

Affter fillup the form we can see in users table in the database. Capture2345

Checklist

bytewiz commented 3 years ago

I would like you to try to use the form hook introduced here: #133

Then, we can also have @Kiran-Serolla review it.

@kamalrsa here https://github.com/HackYourFuture-CPH/rate-my-cv/pull/133/files#diff-27409f699e4e25a0230db85e84dd76c6455b0e971b2babfde38d7029a0a39139

kamalrsa commented 3 years ago

I used hook in my component but if I import the login form i got only two labels email and password instead of that can I create a validation and useform component and import in my signup.js

pdsorensen commented 3 years ago

@kamalrsa aren't those default values? I think you should be able to use it as it as is.

Otherwise, try to edit it so it becomes more flexible.

kamalrsa commented 3 years ago

@kamalrsa aren't those default values? I think you should be able to use it as it as is.

Otherwise, try to edit it so it becomes more flexible.

Ok thanks then I will add the values in useForms what I need more is it ok?

pdsorensen commented 3 years ago

(also, thans for the good reviews @valmdz)