search

HackYourFuture-CPH / rate-my-cv

MIT License
1 stars 2 forks source link

home page slogan developed #145

Closed KavyaReddy732 closed 3 years ago

KavyaReddy732 commented 3 years ago

Description

home page slogan with the button which route to signup page Please provide a short summary explaining what this PR is about. not working in storybook because there is no proptype in signup component. homepage Fixes https://github.com/HackYourFuture-CPH/rate-my-cv/issues/102

How to test?

add this component in container/homepage.js Please provide a short summary how your changes can be tested?

Checklist

pdsorensen commented 3 years ago

Let's have @arya56 review this one first.

pdsorensen commented 3 years ago

I would like you to find another name than registerButton. Something a bit more specific, e.g RegisterPage or maybe someting even better. Cheers!

KavyaReddy732 commented 3 years ago

@pdsorensen we can just use SignUp maybe or add 'register or signup' before the text in paragraph (like: Register and 

Upload your resume to get an evaluation)

pdsorensen commented 3 years ago

@KavyaReddy732 i mean for the components filename. Can't we call it something else? RegisterButton dosen't really reflect the other contents that is in the component.

image