HackYourFuture-CPH / rate-my-cv

MIT License
1 stars 2 forks source link

49 upload new cv using fetch #156

Closed hamedveloper closed 3 years ago

hamedveloper commented 3 years ago

Description

PR is about uploading new CV and rendering in the other page.

Fixes https://github.com/HackYourFuture-CPH/rate-my-cv/issues/49

How to test?

make a connection with firebase by defining your own firebase configuration and put it in the config file. then "npm run dev".

Checklist

hamedveloper commented 3 years ago

I don't really know. I have had this story for around 3 weeks and you knew that and I took about one week to make it and now I can see that all my work is under question. The most part of work is done in #34. when the function gets a file and returns the url. Ok when you have a url you can simply render it in the frontend. I do not get the meaning of frontend and backend both. It could be a mistake like the mistake of assigning one work to two people.

On Fri, Feb 12, 2021 at 6:27 PM Kavya notifications@github.com wrote:

@KavyaReddy732 commented on this pull request.

In src/client/App.js https://github.com/HackYourFuture-CPH/rate-my-cv/pull/156#discussion_r575384940 :

   )}
+ +

because it was my issue and created by daniel and here is issue #83 https://github.com/HackYourFuture-CPH/rate-my-cv/issues/83 and i didn't it on my own hamed and am sorry if i offend you in any way. if you understtod your issue then why it labled as backend and frontend (it should be labeled as only front end)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HackYourFuture-CPH/rate-my-cv/pull/156#discussion_r575384940, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANC53NFRUPJW76EBPCPRRWTS6VQIXANCNFSM4XPKAAXQ .