valmdz commented 3 years ago

... using a reviewer component and a component for the collection of given reviews

Description

This PR contains one folder: SentReviewsComponent, containing 3 files

Two comments are kept to to make it easier to understand the use of the SentReviewsComponent in lines 12 and 20 as shown in the image Screenshot (2543)

Fixes # (issue)

How to test?

Run storybook

SentReviewsComponent should contain 2 examples, one with just 1 sent review, another one with more than 1. Screenshot (2538) Screenshot (2539)

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] This PR is ready to be merged and not breaking any other functionality

valmdz commented 3 years ago

Looks good to me. But I think the 'ReviewPreviewComponent' is out of the story. There is another story for that component. (#89). Otherwise I think everything is fine.

When I started this story I talked with Daniel about the whole component as I had some doubts, but at that time I guess none of us realized that that part would be a component. Thanks for the notice, I think I could use that one of issue #89 once it is merged @Kiran-Serolla I can review yours tomorrow to get it merge, so I can also use it

KavyaReddy732 commented 3 years ago

looks fine for me.

HackYourFuture-CPH / rate-my-cv

Implement sent reviews... #168

Description

How to test?

Checklist