userIsOwner function fix in users.controller

[shpomp]

Description

userIsOwner function fix in users.controller was not designed right. Simplified the query and fixed it.

Fixes #243

How to test?

Try adding a member to the board

Checklist

• [x] I have performed a self-review of my own code
• [x] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
• [x] I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
• [x] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
• [x] This PR is ready to be merged and not breaking any other functionality

[shpomp]

@senner007 I realize now there is no way to add the owner of the board now, as a member with role 'owner'.

Should it be a separate endpoint, or just to pass the role as a parameter here? :

const addMember = async (userId, boardId, memberId) => {
  if (
    !Number.isInteger(Number(userId)) ||
    !Number.isInteger(Number(boardId)) ||
    !Number.isInteger(Number(memberId))
  ) {
    throw new InvalidIdError('Id should be an integer');
  }
  await userIsOwner(userId, boardId);

  const addNewMember = await knex('members').insert({
    boardId,
    userId: memberId,
    role: 'basic',
  });
  return addNewMember;
};

(from members.controller)

[senner007]

role: 'basic',

}); return addNewMember; };

(from members.controller)

Yah, you just want to change the role: 'owner' right?

[senner007]

I'm thinking it makes sense to add the owner as a owner member when the board gets created, right?

[senner007]

@Midnighter What do you think?

[senner007]

Its working fine

Good :) I think you can easily finish your pr before this is merged

[shpomp]

role: 'basic',

}); return addNewMember; };

(from members.controller)

Yah, you just want to change the role: 'owner' right?

yes. We just have no way of adding the owner with role 'owner' as a member to the member table now. Do we need it? If yes, there can be many ways to implement it. Which is the best? Passing the role as param would be the least changes 🙈

[senner007]

role: 'basic',

}); return addNewMember; };

(from members.controller)

Yah, you just want to change the role: 'owner' right?

yes. We just have no way of adding the owner with role 'owner' as a member to the member table now. Do we need it? If yes, there can be many ways to implement it. Which is the best? Passing the role as param would be the least changes 🙈

Ok then create a function with a parameter. When called here the parameter will be 'basic'. But also execute the function with the 'owner' parameter when the board is created

[shpomp]

role: 'basic',

}); return addNewMember; };

(from members.controller)

Yah, you just want to change the role: 'owner' right?

yes. We just have no way of adding the owner with role 'owner' as a member to the member table now. Do we need it? If yes, there can be many ways to implement it. Which is the best? Passing the role as param would be the least changes 🙈

Ok then create a function with a parameter. When called here the parameter will be 'basic'. But also execute the function with the 'owner' parameter when the board is created

Diny suggested a very short and smart solution too:

if(userId===memberId){
    const addNewMember = await knex('members').insert({
      boardId,
      userId: memberId,
      role: 'owner',
    });
    return addNewMember;
  }
  else{
    const addNewMember = await knex('members').insert({
    boardId,
    userId: memberId,
    role: 'basic',
  });
  return addNewMember;
}

What you think about just that?

[senner007]

What you think about just that?

Fine by me if you don't mind adding the owner as member in the frontend also

[senner007]

What you think about just that?

Fine by me if you don't mind adding the owner as member in the frontend also

...and I would still prefer a function since you now have duplicated code

[shpomp]

What you think about just that?

Fine by me if you don't mind adding the owner as member in the frontend also

...and I would still prefer a function since you now have duplicated code

ok! Just to make sure I don't misunderstand - by 'create a function', do you mean just to introduce the role parameter to addMember, right? I would do simply like this:

const addMember = async (userId, boardId, memberId, role) => {
  if (
    !Number.isInteger(Number(userId)) ||
    !Number.isInteger(Number(boardId)) ||
    !Number.isInteger(Number(memberId))
  ) {
    throw new InvalidIdError('Id should be an integer');
  }
  if (role !== 'basic' || role !== 'owner') {
    throw new IncorrectEntryError(`Role should be either 'basic' or 'owner'`);
  }
  await userIsOwner(userId, boardId);

  const addNewMember = await knex('members').insert({
    boardId,
    userId: memberId,
    role: role,
  });
  return addNewMember;
};

[senner007]

What you think about just that?

Fine by me if you don't mind adding the owner as member in the frontend also

...and I would still prefer a function since you now have duplicated code

ok! Just to make sure I don't misunderstand - by 'create a function', do you mean just to introduce the role parameter to addMembr, right? I would do simply like this:

const addMember = async (userId, boardId, memberId, role) => {
  if (
    !Number.isInteger(Number(userId)) ||
    !Number.isInteger(Number(boardId)) ||
    !Number.isInteger(Number(memberId))
  ) {
    throw new InvalidIdError('Id should be an integer');
  }
  if (role !== 'basic' || role !== 'owner') {
    throw new IncorrectEntryError(`Role should be either 'basic' or 'owner'`);
  }
  await userIsOwner(userId, boardId);

  const addNewMember = await knex('members').insert({
    boardId,
    userId: memberId,
    role: role,
  });
  return addNewMember;
};

That's also an option. Now the frontend has to know about the role parameter also. It might come in handy if more roles are added later

[senner007]

I would do simply like this:

const addMember = async (userId, boardId, memberId, role) => {
  if (
    !Number.isInteger(Number(userId)) ||
    !Number.isInteger(Number(boardId)) ||
    !Number.isInteger(Number(memberId))
  ) {
    throw new InvalidIdError('Id should be an integer');
  }
  if (role !== 'basic' || role !== 'owner') {
    throw new IncorrectEntryError(`Role should be either 'basic' or 'owner'`);
  }
  await userIsOwner(userId, boardId);

  const addNewMember = await knex('members').insert({
    boardId,
    userId: memberId,
    role: role,
  });
  return addNewMember;
};

@shpomp Please create an issue for this

[shpomp]

I would do simply like this:

const addMember = async (userId, boardId, memberId, role) => {
  if (
    !Number.isInteger(Number(userId)) ||
    !Number.isInteger(Number(boardId)) ||
    !Number.isInteger(Number(memberId))
  ) {
    throw new InvalidIdError('Id should be an integer');
  }
  if (role !== 'basic' || role !== 'owner') {
    throw new IncorrectEntryError(`Role should be either 'basic' or 'owner'`);
  }
  await userIsOwner(userId, boardId);

  const addNewMember = await knex('members').insert({
    boardId,
    userId: memberId,
    role: role,
  });
  return addNewMember;
};

@shpomp Please create an issue for this

will do! I am working now 🧑‍🏭 , but will make it as soon as I get a moment