HackYourFuture-CPH / simply-name.it

Final Project for Class17

MIT License

3 stars 1 forks source link

Add loading state to Board Page #254

Closed Rasim-Deniz closed 3 years ago

Rasim-Deniz commented 3 years ago

Description

Added loading state to Board Page to control the added or deleted candidates.

Fixes #253

How to test?

npm run dev

Checklist

[X] I have performed a self-review of my own code
[X] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
[X] I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
[X] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
[X] This PR is ready to be merged and not breaking any other functionality

Rasim-Deniz commented 3 years ago

@senner007 Niels, I tried to implement following the way you mentioned but I'm getting this error at the moment. Could you please have a look what is missing? adafaadas

Rasim-Deniz commented 3 years ago

@senner007 Niels, I tried to implement following the way you mentioned but I'm getting this error at the moment. Could you please have a look what is missing?

This error is gone but I don't get the candidates now.

Saidemm commented 3 years ago

@senner007 Niels, I tried to implement following the way you mentioned but I'm getting this error at the moment. Could you please have a look what is missing?

The error is fixed. It seems it doesn't need to send the boardId as a prop in resultButton.

Rasim-Deniz commented 3 years ago

@senner007 Niels, I tried to implement following the way you mentioned but I'm getting this error at the moment. Could you please have a look what is missing?

This error is gone but I don't get the candidates now.

Everything is fixed thanks to Hanieh and Saide! @senner007 Please take a look and let us merge 😄

Rasim-Deniz commented 3 years ago

This duplicates the logic in the other board pr

Conflicts are solved. Can you check if there is any problem? We need this.