search

HackYourFuture / HTML-CSS

70 stars 202 forks source link

remove exercise about floats #84

Closed tomasvanrijsse closed 2 years ago

tomasvanrijsse commented 3 years ago

I think it's a little cruel to make students work with floats while it is considered a bad practice to use floats for layouts.

robvk commented 3 years ago

Think it is time yeah. Should we maybe rethink it a bit and make it an exercise where you have to use grid and flexbox isntead? Thoughts on this?

tomasvanrijsse commented 3 years ago

Well at first I thought it was okay to leave grid out of the homework. The students said that they did learn about grid, but didn't know what to use it for. And that it was harder to work with grid compared to flexbox.

And I just googled to get some other opinions on this subject. https://blog.logrocket.com/flexbox-vs-css-grid/

You should consider using Flexbox when: You have a small design to implement  —  Flexbox is ideal when you have a small layout design to implement, with a few rows or a few columns

CSS grid is better when: You have a complex design to implement  —  in some use cases, we have complex designs to implement, and that’s when the magic of CSS grid shows itself

So applying a CSS grid properly is only to use it for complex layouts. And I wouldn't add that level of difficulty to this first course. It could be a bonus exercise if someone was feeling like it 😛

robvk commented 2 years ago

Finally got round to the HTML/CSS module and changed the exercise to grid/flex. So this is integrated in https://github.com/HackYourFuture/HTML-CSS/pull/89.